Conversation
W1 changed `member` from unique(user_id, hackathon_id) to unique(user_id), but two pieces of documentation still described the old shape — and one of them contradicted the code directly beneath it. - README said `member` is scoped to a hackathon and that "a paid year still hangs off an edition, so membership resolves the current hackathon". That is the bug W1 fixed: the day the next edition opened, every paying member read as a non-member. It now says what is true, including that the club half works with no hackathon in the database at all. - `requireActiveMember`'s docblock claimed it resolves the current edition. The function body does not, and an inner comment said the opposite — a reader had to work out which half to believe. Documentation only; no behaviour change.
…t it (#338) Judges score by scanning the QR on a team's table card: the scoring form only opens after startByQrCode succeeds. TableCards.tsx renders those cards and is the only consumer of judge.tableCards — and nothing imported it, so no card could be printed and no judge could open the form. Judging was unstartable. Lost when I split this work into a stack: branch 1 took the pre-stack version of this page, so the tab and its import never reached main, and the mobile-nav fix (seven tabs in a five-column grid, with Table Cards and Email laid out off the right edge of the phone) went with it. Both are restored here. Found by walking the organiser and judge journeys against main. Nothing failed — the component compiled, 426 tests passed, and the missing tab was invisible to all of it.
…ile (#335) The Membership tab refused to save anything — school, major, skills, interests, socials — unless a graduation year had been typed in, and the error it showed ("That graduation year does not look right") pointed at a field the member had deliberately left empty. The guard compared against `undefined` while the value is `null` for a blank field: `null !== undefined` is true and `Number.isInteger(null)` is false, so every save with an empty year fell into the error branch. `null` is the value that CLEARS the column, so it has to pass. Introduced by the review fix on #323, which changed the payload from `undefined` to `null` to make fields clearable and did not move the guard with it. Found while auditing the product against MVP. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )