fix(model): close jar and classloader via try-with-resources in Exten… - #264
Merged
Merged
Conversation
…sions.loadExtension Previously JarFile and URLClassLoader were closed only at the end of the method, so any exception thrown beforehand leaked both resources. Wrapping them in try-with-resources guarantees they are always closed. Co-authored-by: Cursor <cursoragent@cursor.com>
toku-sa-n
force-pushed
the
fix/extensions-resource-leak
branch
from
July 10, 2026 11:36
1432278 to
2f269f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拡張機能を読み込む際に例外が発生すると、
urlClassLoaderやjarが閉じられず、リソースリークが発生するため、これを修正しました。