Skip to content

[google-apps-script] Calendar API: Adding tests and missing transparency API. CardService: Adding missing SelectionInput enum value#73599

Merged
typescript-bot merged 6 commits into
DefinitelyTyped:masterfrom
gSriviere:master
Sep 2, 2025
Merged

[google-apps-script] Calendar API: Adding tests and missing transparency API. CardService: Adding missing SelectionInput enum value#73599
typescript-bot merged 6 commits into
DefinitelyTyped:masterfrom
gSriviere:master

Conversation

@gSriviere

Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

CalendarEvent / EventTransparency:
https://developers.google.com/apps-script/reference/calendar/calendar-event
https://developers.google.com/apps-script/reference/calendar/event-transparency

CardService / SelectionInputType enum:
https://developers.google.com/apps-script/reference/card-service/selection-input-type

@typescript-bot

typescript-bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

@gSriviere Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73599,
  "author": "gSriviere",
  "headCommitOid": "94025c6b9209007d0318585635cc45264e585f71",
  "mergeBaseOid": "72139e1ec37b6a9da9d64b2019ee5b487923d557",
  "lastPushDate": "2025-09-02T10:45:25.000Z",
  "lastActivityDate": "2025-09-02T15:21:46.000Z",
  "mergeOfferDate": "2025-09-02T15:13:39.000Z",
  "mergeRequestDate": "2025-09-02T15:21:46.000Z",
  "mergeRequestUser": "gSriviere",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "google-apps-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-apps-script/google-apps-script.calendar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.card-service.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/test/google-apps-script-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jpoehnelt",
        "sqrrrl",
        "PierrickVoulet",
        "vinay-google"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jpoehnelt",
      "date": "2025-09-02T15:12:59.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3244797314,
  "ciResult": "pass"
}

@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @jpoehnelt @sqrrrl @PierrickVoulet @vinay-google — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS

Copy link
Copy Markdown

Formatting

The following files are not formatted:

  1. types/google-apps-script/test/google-apps-script-tests.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 94025c6

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 2, 2025
@typescript-bot

Copy link
Copy Markdown
Contributor

@gSriviere: Everything looks good here. I am ready to merge this PR (at 94025c6) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jpoehnelt, @sqrrrl, @PierrickVoulet, @vinay-google: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Sep 2, 2025
@gSriviere

Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 2, 2025
@typescript-bot
typescript-bot merged commit 96a65bf into DefinitelyTyped:master Sep 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants