upload-debug-info-to-sentry.py: Upload binaries in addition to debug files#462
Merged
Conversation
…files This should provide better stack unwinding in Sentry.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ELF processing loop now appends each discovered non‑Darwin binary to the upload list immediately, then attempts build-id extraction and debuginfo lookup. If no separate debuginfo is found, the script logs that and proceeds (the binary is already queued). ChangesBinary upload timing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
cole-h
previously approved these changes
May 18, 2026
grahamc
previously approved these changes
May 18, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
maintainers/upload-debug-info-to-sentry.py (1)
134-137:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winRemove duplicate append to prevent uploading the same binary twice.
Line 131 now unconditionally appends every library to the upload list. Line 136 appends the library again when there's no build ID, creating a duplicate entry in
files_to_upload. The duplicate will cause the same file to be uploaded twice to Sentry.🐛 Proposed fix to remove duplicate append
build_id = get_build_id(lib) if build_id is None: print(f" {lib} (no build ID, uploading binary)", file=sys.stderr) - debug_files.append(lib) continue🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@maintainers/upload-debug-info-to-sentry.py` around lines 134 - 137, The code is appending the same library twice to the upload list: one unconditional append earlier (files_to_upload or debug_files) and a second append in the no-build-id branch (debug_files.append(lib)); remove the duplicate by deleting the conditional append inside the if build_id is None block (or move the unconditional append into the else branch) so each library is added exactly once; update references to build_id, debug_files and files_to_upload accordingly to ensure only a single append happens per library.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@maintainers/upload-debug-info-to-sentry.py`:
- Around line 134-137: The code is appending the same library twice to the
upload list: one unconditional append earlier (files_to_upload or debug_files)
and a second append in the no-build-id branch (debug_files.append(lib)); remove
the duplicate by deleting the conditional append inside the if build_id is None
block (or move the unconditional append into the else branch) so each library is
added exactly once; update references to build_id, debug_files and
files_to_upload accordingly to ensure only a single append happens per library.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3801a0e4-70f4-4cab-8c96-fd25b69d6170
📒 Files selected for processing (1)
maintainers/upload-debug-info-to-sentry.py
cole-h
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This should provide better stack unwinding in Sentry.
Context
Summary by CodeRabbit