Skip to content

Detach Scheduler pointerup events on workspace disposing #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yarovaya merged 2 commits into from
Jan 16, 2019
Merged

Detach Scheduler pointerup events on workspace disposing #6579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e0da7
Trying to fix
Yarovaya Jan 15, 2019
fb6f8b9
Fix tests
Yarovaya Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions js/ui/scheduler/ui.scheduler.work_space.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,6 +1738,12 @@ var SchedulerWorkSpace = Widget.inherit({
delete this._interval;
},

_clean: function() {
eventsEngine.off(domAdapter.getDocument(), SCHEDULER_CELL_DXPOINTERUP_EVENT_NAME);

this.callBase();
},

getWorkArea: function() {
return this._dateTableScrollable.$content();
},
Expand Down
19 changes: 19 additions & 0 deletions testing/tests/DevExpress.ui.widgets.scheduler/workSpace.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,6 +1582,25 @@ QUnit.testStart(function() {
assert.equal(cells.slice(1, 10).filter(".dx-state-focused").length, 9, " right cells are focused");
});

QUnit.test("Pointeruip event subscriptions should be detached on dispose", function(assert) {
var $element = $("#scheduler-work-space").dxSchedulerWorkSpaceMonth({
focusStateEnabled: true,
firstDayOfWeek: 1,
currentDate: new Date(2015, 3, 1)
}),
keyboard = keyboardMock($element);

var cells = $element.find("." + CELL_CLASS);

pointerMock(cells.eq(3)).start().click();
keyboard.keyDown("left", { shiftKey: true });
keyboard.keyDown("right", { shiftKey: true });

$element.dxSchedulerWorkSpaceMonth("instance").dispose();

assert.equal($._data(document, "events"), undefined, "Event subscriptions were detached");
});

QUnit.test("Workspace should allow select/unselect cells with shift & right/left arrow", function(assert) {
var $element = $("#scheduler-work-space").dxSchedulerWorkSpaceMonth({
focusStateEnabled: true,
Expand Down