Skip to content

Change oav parameters direction attribute to enum from int - #2092

Merged
rtuck99 merged 1 commit into
mainfrom
fixes_for_mx_bluesky_ophyd_async_changes
Jun 12, 2026
Merged

Change oav parameters direction attribute to enum from int#2092
rtuck99 merged 1 commit into
mainfrom
fixes_for_mx_bluesky_ophyd_async_changes

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Changes OAVParameters so that direction attribute is of type ShutterState instead of int.

Required for

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (a979c80) to head (4b4ec54).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         344      344           
  Lines       13387    13388    +1     
=======================================
+ Hits        13273    13274    +1     
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99
rtuck99 marked this pull request as ready for review June 12, 2026 11:14
@rtuck99
rtuck99 requested a review from a team as a code owner June 12, 2026 11:14

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving to get this over the line but there's some weird things going on here...

It feels like this should have been caught by a test in dodal but on further investigation direction is never used in dodal. Instead, setup_pin_tip_detection takes a direction and uses that. However, MX have their own setup_pin_tip_detection_params, which does use the direction. I think this is either a side-effect of when @noemifrisina split out the pin tip detection to be into dodal rather than mx-bluesky or when we were trying to get pin tip centring working on aithre. I suggest we try and combine these, I'll make an issue and investigate if I get time

@rtuck99
rtuck99 enabled auto-merge (squash) June 12, 2026 14:27
@rtuck99
rtuck99 force-pushed the fixes_for_mx_bluesky_ophyd_async_changes branch from 97eb918 to 4b4ec54 Compare June 12, 2026 14:27
@rtuck99
rtuck99 merged commit e4c528d into main Jun 12, 2026
10 checks passed
@rtuck99
rtuck99 deleted the fixes_for_mx_bluesky_ophyd_async_changes branch June 12, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants