Change oav parameters direction attribute to enum from int - #2092
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 344 344
Lines 13387 13388 +1
=======================================
+ Hits 13273 13274 +1
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, approving to get this over the line but there's some weird things going on here...
It feels like this should have been caught by a test in dodal but on further investigation direction is never used in dodal. Instead, setup_pin_tip_detection takes a direction and uses that. However, MX have their own setup_pin_tip_detection_params, which does use the direction. I think this is either a side-effect of when @noemifrisina split out the pin tip detection to be into dodal rather than mx-bluesky or when we were trying to get pin tip centring working on aithre. I suggest we try and combine these, I'll make an issue and investigate if I get time
97eb918 to
4b4ec54
Compare
Changes
OAVParametersso thatdirectionattribute is of typeShutterStateinstead of int.Required for
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}