Skip to content

Allow for all scan directions in the OAV parameters - #2138

Merged
rtuck99 merged 3 commits into
mainfrom
fix-oav-params-direction
Jul 28, 2026
Merged

Allow for all scan directions in the OAV parameters#2138
rtuck99 merged 3 commits into
mainfrom
fix-oav-params-direction

Conversation

@noemifrisina

@noemifrisina noemifrisina commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Temporarily reverts #2092 and changes the OAVParameters direction in order to allow values different from 0 and 1 from the OAVCentring file, eg. I19-1 has a direction value of "2", which is "up".

This issues should be fixed properly in a separate PR.

Instructions to reviewer on how to test:

  1. Run tests

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@noemifrisina
noemifrisina requested a review from a team as a code owner July 28, 2026 15:19
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (4463efb) to head (40e856c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
- Coverage   99.16%   99.16%   -0.01%     
==========================================
  Files         354      354              
  Lines       13832    13831       -1     
==========================================
- Hits        13716    13715       -1     
  Misses        116      116              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noemifrisina
noemifrisina requested a review from rtuck99 July 28, 2026 15:29

@rtuck99 rtuck99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rtuck99
rtuck99 merged commit fa1d92a into main Jul 28, 2026
11 checks passed
@rtuck99
rtuck99 deleted the fix-oav-params-direction branch July 28, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants