Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Improve the use of the pin tip detect device#708

Merged
d-perl merged 1 commit into
mainfrom
699_fix_pin_detect
Jun 7, 2023
Merged

Improve the use of the pin tip detect device#708
d-perl merged 1 commit into
mainfrom
699_fix_pin_detect

Conversation

@DominicOram

Copy link
Copy Markdown
Collaborator

Fixes #699

Link to dodal PR (if required): DiamondLightSource/dodal#88

To test:

  1. Confirm modified unit tests pass and code is cleaner

@codecov

codecov Bot commented Jun 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #708 (6bd9942) into main (ea8c83a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.02%     
==========================================
  Files          34       34              
  Lines        1668     1666       -2     
==========================================
- Hits         1528     1526       -2     
  Misses        140      140              
Impacted Files Coverage Δ
...rtemis/experiment_plans/oav_grid_detection_plan.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d-perl d-perl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this!

@d-perl
d-perl merged commit 3ea37c1 into main Jun 7, 2023
@d-perl
d-perl deleted the 699_fix_pin_detect branch June 7, 2023 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix pin tip detect

2 participants