Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Tests for full grid scan#730

Merged
d-perl merged 8 commits into
mainfrom
tests_for_full_grid_scan
Jun 14, 2023
Merged

Tests for full grid scan#730
d-perl merged 8 commits into
mainfrom
tests_for_full_grid_scan

Conversation

@Tom-Willemsen

@Tom-Willemsen Tom-Willemsen commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Fixes #674

Adds a unit test for full_grid_scan

Note: depends on #722

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, minor tidying up I think you could do. Also some minor workflow issues:

  • We usually to add the issue number in the branch name and commit messages e.g. see #708. People are a bit hit and miss about it though, not a big deal.
  • vscode should be sorting imports on save, do you have the following in your settings.json?
"editor.codeActionsOnSave": {
        "source.organizeImports": true
    },
    "python.sortImports.args": [
        "--profile",
        "black"
    ],

Comment thread src/artemis/experiment_plans/tests/conftest.py Outdated
Comment thread src/artemis/experiment_plans/full_grid_scan.py
Comment thread src/artemis/experiment_plans/tests/test_full_grid_scan_plan.py Outdated
Comment thread src/artemis/experiment_plans/tests/test_full_grid_scan_plan.py Outdated
Comment thread src/artemis/experiment_plans/tests/test_full_grid_scan_plan.py Outdated
Comment thread src/artemis/experiment_plans/tests/test_full_grid_scan_plan.py Outdated
@codecov

codecov Bot commented Jun 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #730 (159a335) into main (f6d5c41) will increase coverage by 1.96%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   91.57%   93.54%   +1.96%     
==========================================
  Files          34       34              
  Lines        1674     1673       -1     
==========================================
+ Hits         1533     1565      +32     
+ Misses        141      108      -33     
Impacted Files Coverage Δ
src/artemis/experiment_plans/full_grid_scan.py 100.00% <100.00%> (+29.85%) ⬆️
...plan_specific/grid_scan_with_edge_detect_params.py 100.00% <100.00%> (+35.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, wait until #722 is merged but otherwise fine, thank you!

@d-perl

d-perl commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

merging as #722 is merged now

@d-perl
d-perl merged commit 08e6505 into main Jun 14, 2023
@d-perl
d-perl deleted the tests_for_full_grid_scan branch June 14, 2023 13:22
@d-perl d-perl mentioned this pull request Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more tests around full_grid_scan

3 participants