This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Tests for full grid scan#730
Merged
Merged
Conversation
DominicOram
suggested changes
Jun 13, 2023
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Generally good, minor tidying up I think you could do. Also some minor workflow issues:
- We usually to add the issue number in the branch name and commit messages e.g. see #708. People are a bit hit and miss about it though, not a big deal.
- vscode should be sorting imports on save, do you have the following in your
settings.json?
"editor.codeActionsOnSave": {
"source.organizeImports": true
},
"python.sortImports.args": [
"--profile",
"black"
],
added 2 commits
June 13, 2023 17:25
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 91.57% 93.54% +1.96%
==========================================
Files 34 34
Lines 1674 1673 -1
==========================================
+ Hits 1533 1565 +32
+ Misses 141 108 -33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
approved these changes
Jun 13, 2023
Collaborator
There was a problem hiding this comment.
Looks good, wait until #722 is merged but otherwise fine, thank you!
Contributor
|
merging as #722 is merged now |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #674
Adds a unit test for
full_grid_scanNote: depends on #722