Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Bump parameter version to 1.0.0#721

Merged
d-perl merged 3 commits into
mainfrom
update_params_version
Jun 14, 2023
Merged

Bump parameter version to 1.0.0#721
d-perl merged 3 commits into
mainfrom
update_params_version

Conversation

@DominicOram

@DominicOram DominicOram commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

To test:

  1. Confirm unit tests are still passing
  2. Confirm I haven't missed anywhere we're still referring to "0.0.5"
  3. Run https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/39272/1 against this branch and confirm you do not get a validation error on the parameter version (you will instead get GridScanWithEdgeDetectInternalParameters fails on init #718)
  4. +2 the associated gerrit change if you're happy with it

@noemifrisina noemifrisina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test failing because of an AttributeError in GridScanParams. The fix is already in main, so merging main should fix it

@DominicOram

Copy link
Copy Markdown
Collaborator Author

One test failing because of an AttributeError in GridScanParams. The fix is already in main, so merging main should fix it

Done

@DominicOram
DominicOram requested a review from noemifrisina June 13, 2023 16:37
@codecov

codecov Bot commented Jun 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #721 (b58b9e6) into main (9b15975) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          35       35           
  Lines        1721     1721           
=======================================
  Hits         1584     1584           
  Misses        137      137           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d-perl d-perl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, behaves as described, have +2'd on gerrit

@d-perl
d-perl dismissed noemifrisina’s stale review June 14, 2023 12:58

changes have been addressed

@d-perl
d-perl merged commit b8b5aac into main Jun 14, 2023
@d-perl
d-perl deleted the update_params_version branch June 14, 2023 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants