This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Fix bug in API for grid scan with edge detection#722
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #722 +/- ##
==========================================
+ Coverage 91.59% 92.37% +0.78%
==========================================
Files 34 34
Lines 1666 1666
==========================================
+ Hits 1526 1539 +13
+ Misses 140 127 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d-perl
approved these changes
Jun 14, 2023
d-perl
left a comment
d-perl
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that tests pass, also that it can be triggered from GDA now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #718
Note this is based off #721, ensure that PR is reviewed/merged first
To test: