This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Use callbacks in grid detection plan#731
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 93.95% 94.01% +0.05%
==========================================
Files 35 36 +1
Lines 1721 1737 +16
==========================================
+ Hits 1617 1633 +16
Misses 104 104
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
suggested changes
Jun 13, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Minor comments in code, I think we should also merge #730 first so that we can ensure it doesn't break tests
| oav_callback = OavSnapshotCallback() | ||
| yield from bps.subscribe(oav_callback) | ||
|
|
||
| yield from grid_detection_plan( |
Collaborator
There was a problem hiding this comment.
Should: I think you can do the subscribe/unsubscribe in a decorator
| path_join(snapshot_dir, f"{snapshot_filename}.png"), | ||
| ] | ||
| ) | ||
| yield from bps.create("snapshot_directories") |
Collaborator
There was a problem hiding this comment.
Should: This isn't just directories any more
This was referenced Jun 13, 2023
Collaborator
Contributor
Author
|
Done, thanks |
Collaborator
|
Could you:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #671
Link to dodal PR (if required): #91
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test:
1.Run tests