fix(ci): pin pnpm and strip v prefix in sync-version job - #4984
Merged
Conversation
npm install -g pnpm resolved to pnpm 11, which turns the esbuild ignored-build-scripts warning into a fatal error, so sync-version has failed on every release since v0.29.5 and mcp/cli/sdk were never bumped or published. Pin pnpm to 10.22.0 (same as packageManager) and write the version without the v prefix so npm packages get valid semver.
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - uses: pnpm/action-setup@v4 |
Contributor
There was a problem hiding this comment.
Mutable release action reference
pnpm/action-setup@v4 uses a mutable third-party tag in a release job that later handles DOCS_SYNC_TOKEN and pushes to three downstream repositories. Pinning the action to its full commit SHA prevents upstream tag replacement from silently changing the code executed by this job.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
ZoharKiaav
pushed a commit
to ZoharKiaav/stacker
that referenced
this pull request
Aug 7, 2026
fix(ci): pin pnpm and strip v prefix in sync-version job (cherry picked from commit 53feb9d) [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sync-versionjob has failed on every release since v0.29.5, so mcp/cli/sdk never got version bumps and nothing was published to npm since May (sdk/cli stuck at 0.29.4, mcp at 0.29.3).Two causes:
npm install -g pnpminstalls latest (pnpm 11), which turns the esbuild ignored-build-scripts warning into a fatalERR_PNPM_IGNORED_BUILDS(exit 1) on the MCP step, killing the job before the CLI/SDK steps run. Replaced withpnpm/action-setup@v4pinned to 10.22.0, matching the repo'spackageManager.package.jsonversion carries avprefix (v0.29.14), which the job copied verbatim into the npm packages'package.json— invalid npm semver, and their publish workflows would producevv*tags. Newnpm_versionoutput strips the prefix; the dokploy release tag keeps its current format.Verified locally: pnpm 11 reproduces the exact CI failure on the mcp repo; with pnpm 10.22.0 the full MCP step (install + fetch-openapi + generate) passes clean.
Greptile Summary
The PR repairs downstream package synchronization by installing the repository-aligned pnpm version and separating the v-prefixed Dokploy release version from the bare npm package version.
npm_versionjob output that strips the leadingvfor MCP, CLI, and SDK package metadata.pnpm/action-setupconfigured for pnpm 10.22.0.Confidence Score: 4/5
The PR appears safe to merge, with one non-blocking supply-chain hardening opportunity in the newly added action reference.
The version normalization and pnpm setup align with the current release format and repository package-manager version; the remaining concern is that the new third-party action can change without a reviewed workflow update because it is not pinned to an immutable commit.
Files Needing Attention: .github/workflows/dokploy.yml
Security Review
The new package-manager setup action uses a mutable third-party action tag. Pinning it to the corresponding full commit SHA would harden the release job against upstream tag replacement.
Reviews (1): Last reviewed commit: "fix(ci): pin pnpm and strip v prefix in ..." | Re-trigger Greptile