Skip to content

fix(ci): generate OpenAPI spec from the release commit in sync-version - #4985

Open
Siumauricio wants to merge 1 commit into
canaryfrom
fix/sync-version-release-spec
Open

fix(ci): generate OpenAPI spec from the release commit in sync-version#4985
Siumauricio wants to merge 1 commit into
canaryfrom
fix/sync-version-release-spec

Conversation

@Siumauricio

@Siumauricio Siumauricio commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #4984. The cli/sdk sync steps copied the repo-root openapi.json, which was last committed in March (450 paths vs 546 in the current API), and the mcp step fetched docs.dokploy.com/openapi.json, which any canary push can overwrite with unreleased API.

sync-version now runs pnpm generate:openapi on the release commit checkout and feeds that spec to all three repos, so each package release matches the API of its dokploy tag.

Greptile Summary

The PR generates OpenAPI from the checked-out release commit and reuses that artifact while synchronizing the MCP, CLI, and SDK repositories.

  • Adds Node setup and release-checkout OpenAPI generation to the sync-version job.
  • Replaces MCP's remote specification fetch with the locally generated specification.
  • Keeps all downstream package generation aligned with the API represented by the Dokploy release tag.

Confidence Score: 4/5

The PR appears safe to merge, with one non-blocking supply-chain hardening issue in the newly added release-workflow action reference.

The OpenAPI generation and downstream copy paths are internally consistent, but the new mutable setup-node reference adds avoidable third-party code exposure before the job uses credentials for three repositories.

Files Needing Attention: .github/workflows/dokploy.yml

Reviews (1): Last reviewed commit: "fix(ci): generate OpenAPI spec from the ..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

The cli/sdk steps copied the repo-root openapi.json, which was last committed in March, and the mcp step fetched docs.dokploy.com, which canary pushes can overwrite. Generate the spec from the release commit instead so each package release matches its dokploy tag.
@Siumauricio Siumauricio added the hotfix Cherry-pick this fix to main for next patch release label Aug 6, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 6, 2026
with:
version: 10.22.0

- uses: actions/setup-node@v4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 security Mutable release action reference

If the actions/setup-node@v4 tag is repointed, the release job executes changed third-party code before using DOCS_SYNC_TOKEN to access three downstream repositories, exposing credentials and generated artifacts to tampering. Pin this action to an immutable commit SHA. How this was verified: The new action runs before the authenticated MCP, CLI, and SDK clone steps in the same job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix Cherry-pick this fix to main for next patch release size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant