fix(ci): generate OpenAPI spec from the release commit in sync-version - #4985
Open
Siumauricio wants to merge 1 commit into
Open
fix(ci): generate OpenAPI spec from the release commit in sync-version#4985Siumauricio wants to merge 1 commit into
Siumauricio wants to merge 1 commit into
Conversation
The cli/sdk steps copied the repo-root openapi.json, which was last committed in March, and the mcp step fetched docs.dokploy.com, which canary pushes can overwrite. Generate the spec from the release commit instead so each package release matches its dokploy tag.
| with: | ||
| version: 10.22.0 | ||
|
|
||
| - uses: actions/setup-node@v4 |
Contributor
There was a problem hiding this comment.
Mutable release action reference
If the actions/setup-node@v4 tag is repointed, the release job executes changed third-party code before using DOCS_SYNC_TOKEN to access three downstream repositories, exposing credentials and generated artifacts to tampering. Pin this action to an immutable commit SHA. How this was verified: The new action runs before the authenticated MCP, CLI, and SDK clone steps in the same job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4984. The cli/sdk sync steps copied the repo-root
openapi.json, which was last committed in March (450 paths vs 546 in the current API), and the mcp step fetcheddocs.dokploy.com/openapi.json, which any canary push can overwrite with unreleased API.sync-versionnow runspnpm generate:openapion the release commit checkout and feeds that spec to all three repos, so each package release matches the API of its dokploy tag.Greptile Summary
The PR generates OpenAPI from the checked-out release commit and reuses that artifact while synchronizing the MCP, CLI, and SDK repositories.
Confidence Score: 4/5
The PR appears safe to merge, with one non-blocking supply-chain hardening issue in the newly added release-workflow action reference.
The OpenAPI generation and downstream copy paths are internally consistent, but the new mutable setup-node reference adds avoidable third-party code exposure before the job uses credentials for three repositories.
Files Needing Attention: .github/workflows/dokploy.yml
Reviews (1): Last reviewed commit: "fix(ci): generate OpenAPI spec from the ..." | Re-trigger Greptile