[v3] fix: fall back to login when the AuthMe reconnect prompt never arrives - #60
Merged
Merged
Conversation
AuthMe sometimes sends no login/register prompt at all when a pool account reconnects, so the plugin waited out its full timeout and failed the whole test even though the server would have accepted a plain /login. Catch that timeout and assume login (never registration -- a silent reconnect can only happen to an account that already exists). The existing success/authenticated patterns already match "already logged in", so a stale session on the server just costs one extra command instead of stranding the bot online for the rest of the run. Closes Drownek#57
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57.
A pool account reconnecting sometimes gets no login/register prompt at all — AuthMe stays silent, and the plugin burned its full 15s timeout waiting for something that was never coming. One missed prompt failed the whole connection, and on
v3-devthat stranded the bot online, so the next test got kicked with "already playing" and the failure cascaded through the rest of the run.The plugin now catches that timeout and assumes login (never registration — a silent reconnect can only happen to an account that already exists), then sends
/loginanyway.successPatternandauthenticatedPatternalready match "already logged in" as a substring, so if AuthMe considers the session still active, the extra command just gets accepted instead of leaving the bot stuck.Root cause of the missing prompt itself is still open — this only stops it from taking the rest of the run down with it.
Verified on both stands (
example_plugin,feat/53-serial-identity→ this branch):plugwrightTestLocal: 50/50 passplugwrightTestStand(hand-started server, same as [v3] AuthMe login prompt sometimes never arrives when a pool account reconnects #57's repro): 44/44 pass, 6 skip — 0 fail, vs. 2 failed in the run that surfaced [v3] AuthMe login prompt sometimes never arrives when a pool account reconnects #57