Skip to content

[v3] fix: fall back to login when the AuthMe reconnect prompt never arrives #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Drownek merged 1 commit into from
Aug 28, 2026
Merged

[v3] fix: fall back to login when the AuthMe reconnect prompt never arrives #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion auth-authme-package/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ export default definePlugin<AuthAuthmeOptions>({
const since = (index: number, pattern: RegExp): string | undefined =>
player.messageBuffer.slice(index).find((m: string) => pattern.test(m));

// The server occasionally sends no prompt at all on a reconnect (#57) — AuthMe still
// considers the account logged in from a connection that never fully closed. Rather
// than fail the whole test over one missing prompt, assume login (never registration:
// a silent reconnect can only happen to an account that already exists) and let the
// command below run into either a real prompt AuthMe queued up in the meantime, or an
// "already logged in" reply — both success/authenticated patterns already match it.
const isRegistration = await poll(
() => {
if (since(joinIndex, registerPrompt)) return true;
Expand All @@ -107,7 +113,7 @@ export default definePlugin<AuthAuthmeOptions>({
timeout: resolved.timeoutMs,
message: `authme: never saw a login or register prompt for "${account.username}"`,
},
);
).catch(() => false);

// Everything below only looks at messages newer than the command. A server's greeting
// often carries a word like "welcome", which would otherwise pass for confirmation
Expand Down
Loading