Skip to content

Conversation

@pinzart90
Copy link
Contributor

@pinzart90 pinzart90 commented Feb 12, 2024

add automated tests

<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<PlatformTarget >x64</PlatformTarget>
<TargetFramework>net8.0</TargetFramework>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added targetframework to each project to be easier to understand

Ex. open a command line in the DynamoSamples directory and run:
dotnet test %cd%\src\SampleLibraryTests -p:Configuration=Release - -filter "TestCategory!=Failure" - -logger "trx;LogFileName=results.trx" - -results-directory TestResults
Note: The - -filter, - -logger and - -results-directory should have double dashes without a space in between. -->
<SolutionDir>$(MSBuildThisFileDirectory)\</SolutionDir>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

class HelloDynamoZeroTouchTests : GeometricTestBase
{
[Test]
[Category("NEEDS_ASM")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should call this ASM - maybe geo lib or something less ADSK speak.

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good @pinzart90 - I did run into the issue I mentioned the other day again, some tests failing discovery because Dynamo's binaries are not around at discovery time.

This is especially an issue when writing tests for packages using AssemblyLoadContext isolation because there are likely conflicting dependencies with Dynamo and dumping your test binaries into the DynamoCore folder is going to put you right back into that mess.

I was curious if we have that filed somewhere? (not a blocker for merging this of course)

@pinzart90
Copy link
Contributor Author

it looks good @pinzart90 - I did run into the issue I mentioned the other day again, some tests failing discovery because Dynamo's binaries are not around at discovery time.

This is especially an issue when writing tests for packages using AssemblyLoadContext isolation because there are likely conflicting dependencies with Dynamo and dumping your test binaries into the DynamoCore folder is going to put you right back into that mess.

I was curious if we have that filed somewhere? (not a blocker for merging this of course)

YEs, tracked internally DYN-6591

@pinzart90 pinzart90 merged commit 75e73b8 into master Feb 13, 2024
@pinzart90 pinzart90 deleted the add_tests branch February 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants