Skip to content

More hierarchical parallelism wrappers in VertCoord.cpp#344

Merged
mark-petersen merged 1 commit intoE3SM-Project:developfrom
mwarusz:omega/vert-coord-hipar
Mar 18, 2026
Merged

More hierarchical parallelism wrappers in VertCoord.cpp#344
mark-petersen merged 1 commit intoE3SM-Project:developfrom
mwarusz:omega/vert-coord-hipar

Conversation

@mwarusz
Copy link
Copy Markdown
Member

@mwarusz mwarusz commented Feb 16, 2026

Some parallel loops in VertCoord.cpp predate the introduction of hierarchical parallelism wrappers. I made copilot update them.

Checklist

  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests

@brian-oneill
Copy link
Copy Markdown

Approved based on inspection and successful execution of ctests on Chrysalis, pm-cpu, and pm-gpu

@mwarusz mwarusz force-pushed the omega/vert-coord-hipar branch from 68e4e40 to 562e179 Compare March 13, 2026 17:11
@mwarusz
Copy link
Copy Markdown
Member Author

mwarusz commented Mar 16, 2026

Testing

CTest unit tests:

Machine: pm-cpu
Compiler: gnu
Build type: Release
Result: All 39 tests passed
Log: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/build-pm-cpu-gnu/Testing/Temporary/LastTest.log

CTest unit tests:

Machine: pm-gpu
Compiler: gnugpu
Build type: Release
Result: All 39 tests passed
Log: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/build-pm-gpu-gnugpu/Testing/Temporary/LastTest.log

Polaris omega_pr suite:

Machine: pm-cpu
Compiler: gnu
Baseline workdir: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/baseline-pm-cpu-gnu
Baseline build: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/baseline-pm-cpu-gnu/build
PR build: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/build-pm-cpu-gnu
PR workdir: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/pr-pm-cpu-gnu
Build type: <Release>
Log: /pscratch/sd/m/mwarusz/omega-pr-testing/vert-coord-hipar/pr-pm-cpu-gnu/polaris_omega_pr.o50039678
Result: All tests passed

Note: Similarly to #361, the baseline was with the current develop.

@mark-petersen mark-petersen self-assigned this Mar 18, 2026
@mark-petersen mark-petersen merged commit fdd7ba5 into E3SM-Project:develop Mar 18, 2026
1 check passed
xylar added a commit to xylar/polaris that referenced this pull request Mar 27, 2026
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/Omega#343
- [ ]  (ocn) E3SM-Project/Omega#344
- [ ]  (ocn) E3SM-Project/Omega#226
- [ ]  (ocn) E3SM-Project/Omega#369
- [ ]  (ocn) E3SM-Project/Omega#379
xylar added a commit to xylar/polaris that referenced this pull request Mar 27, 2026
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/Omega#343
- [ ]  (ocn) E3SM-Project/Omega#344
- [ ]  (ocn) E3SM-Project/Omega#226
- [ ]  (ocn) E3SM-Project/Omega#369
- [ ]  (ocn) E3SM-Project/Omega#379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants