Update global constants to use PCD 0.1.0 values#372
Merged
xylar merged 1 commit intoE3SM-Project:developfrom Mar 26, 2026
Merged
Update global constants to use PCD 0.1.0 values#372xylar merged 1 commit intoE3SM-Project:developfrom
xylar merged 1 commit intoE3SM-Project:developfrom
Conversation
Author
TesingCTest unit tests:
Polaris
|
Author
|
It's interesting that everything passes -- clearly nothing we're testing uses the Coriolis parameter yet. |
Author
|
Polaris testing requires E3SM-Project/polaris#505. |
This was referenced Mar 22, 2026
Author
|
@katsmith133, this is ready to review in conjunction with #371, which is required to bring in the necessary version of PCD. |
Author
|
I'll rebase this following #371 |
This merge updates Omega's global constants to use PCD values wherever possible. Most constants are unchanged. However, these constants have changed in value: * `SDay`: 86164.0 -> 86164.10063718943 * `Omega`: 7.292123516990375e-05 -> 7.292115e-05 * `RhoAir`: 1.2 -> 1.2923190576466714 * `CpAir`: 1005.0 -> 1004.64 * `CpIce`: 2108.0 -> 2117.27 * `Sound`: 150.0 -> 1500.0 (old value was a bug)
6e8ba4c to
2ef15ae
Compare
katsmith133
approved these changes
Mar 26, 2026
katsmith133
left a comment
There was a problem hiding this comment.
All ctests pass on PM-CPU and PM-GPU and a visual inspection of code changes make sense to me.
@xylar would you like for me to run omega_pr tests too?
Author
|
@katsmith133, no need. I think I have that covered. Just wanted another set of eyes on these changes and you're the person most familiar with this part of the code. Thanks very much! |
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Mar 26, 2026
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Mar 27, 2026
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge updates Omega's global constants to use PCD values wherever possible. Most constants are unchanged. However, these constants have changed in value:
SDay: 86164.0 -> 86164.10063718943Omega: 7.292123516990375e-05 -> 7.292115e-05RhoAir: 1.2 -> 1.2923190576466714CpAir: 1005.0 -> 1004.64CpIce: 2108.0 -> 2117.27Sound: 150.0 -> 1500.0 (old value was a bug)Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildFixes #179