Skip to content

Update global constants to use PCD 0.1.0 values#372

Merged
xylar merged 1 commit intoE3SM-Project:developfrom
xylar:omega/update-constants-from-pcd-0.1.0
Mar 26, 2026
Merged

Update global constants to use PCD 0.1.0 values#372
xylar merged 1 commit intoE3SM-Project:developfrom
xylar:omega/update-constants-from-pcd-0.1.0

Conversation

@xylar
Copy link
Copy Markdown

@xylar xylar commented Mar 22, 2026

This merge updates Omega's global constants to use PCD values wherever possible. Most constants are unchanged. However, these constants have changed in value:

  • SDay: 86164.0 -> 86164.10063718943
  • Omega: 7.292123516990375e-05 -> 7.292115e-05
  • RhoAir: 1.2 -> 1.2923190576466714
  • CpAir: 1005.0 -> 1004.64
  • CpIce: 2108.0 -> 2117.27
  • Sound: 150.0 -> 1500.0 (old value was a bug)

Checklist

  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests

Fixes #179

@xylar xylar requested a review from katsmith133 March 22, 2026 10:13
@xylar xylar self-assigned this Mar 22, 2026
@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 22, 2026

Tesing

CTest unit tests:

  • Machine: chrysalis
  • Compiler: intel
  • Build type: Release
  • Result: All tests passed
  • Log: /lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260322/omega-pr-pcd-0.1.0/build/ctests.log

Polaris omega_pr suite

  • Baseline workdir: /lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260322/omega-pr-baseline
  • Baseline build: /lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260322/omega-pr-baseline/build
  • PR build: /lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260322/omega-pr-pcd-0.1.0/build
  • PR workdir: /lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260322/omega-pr-pcd-0.1.0
  • Machine: chrysalis
  • Partition: compute
  • Compiler: intel
  • Build type: Release
  • Log: /lcrc/group/e3sm/ac.xylar/polaris_1.0/chrysalis/test_20260322/omega-pr-pcd-0.1.0/polaris_omega_pr.o1201127
  • Result: All tests passed

@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 22, 2026

It's interesting that everything passes -- clearly nothing we're testing uses the Coriolis parameter yet.

@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 22, 2026

Polaris testing requires E3SM-Project/polaris#505.

@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 22, 2026

@katsmith133, this is ready to review in conjunction with #371, which is required to bring in the necessary version of PCD.

@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 26, 2026

I'll rebase this following #371

This merge updates Omega's global constants to use PCD values
wherever possible.  Most constants are unchanged.  However,
these constants have changed in value:
* `SDay`: 86164.0 -> 86164.10063718943
* `Omega`: 7.292123516990375e-05 -> 7.292115e-05
* `RhoAir`: 1.2 -> 1.2923190576466714
* `CpAir`: 1005.0 -> 1004.64
* `CpIce`: 2108.0 -> 2117.27
* `Sound`: 150.0 -> 1500.0 (old value was a bug)
@xylar xylar force-pushed the omega/update-constants-from-pcd-0.1.0 branch from 6e8ba4c to 2ef15ae Compare March 26, 2026 20:25
Copy link
Copy Markdown

@katsmith133 katsmith133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ctests pass on PM-CPU and PM-GPU and a visual inspection of code changes make sense to me.

@xylar would you like for me to run omega_pr tests too?

@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 26, 2026

@katsmith133, no need. I think I have that covered. Just wanted another set of eyes on these changes and you're the person most familiar with this part of the code. Thanks very much!

@xylar xylar merged commit 56de8ec into E3SM-Project:develop Mar 26, 2026
1 check passed
@xylar xylar deleted the omega/update-constants-from-pcd-0.1.0 branch March 26, 2026 20:52
xylar added a commit to xylar/polaris that referenced this pull request Mar 27, 2026
xylar added a commit to xylar/polaris that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bringing in shared constants

2 participants