Fix a spelling error in the functor name (PotientialVortHAdv->PotentialVortHAdv)

[hyungyukang]

This PR fixes a spelling error in the function name, changing PotientialVortHAdv to PotentialVortHAdv in Tendencies.cpp, Tendencies.h, and TimeStepperTest.cpp.

Passed Ctests on Frontier CPU (craycray) and GPU (craycray-mphipcc compilers).

• Linting
  • Pre-commit run locally
• Building
  • CMake build does not produce any new warnings from changes in this PR
    Checklist
• Testing
  • Add a comment to the PR titled Testing with the following:
    • Which machines CTest unit tests

[alicebarthel]

Yes, thanks! I am so glad to hear it's not just me who was bothered by the typo ;-)

[mark-petersen]

Thanks @hyungyukang, this is an obvious one! I merged locally on perlmutter it passed all cTests with gnu on CPUs.

[mark-petersen]

I found three more:

git grep -in Potiential
doc/design/Tendencies.md:48:   PotentialVortHAdvOnEdge PotientialVortHAdv;
src/ocn/Tendencies.cpp:401:      Pacer::start("Tend:potientialVortHAdv", 2);
src/ocn/Tendencies.cpp:415:      Pacer::stop("Tend:potientialVortHAdv", 2);

I'll fix those quick.

[mark-petersen]

Note, I altered the ekat and CIME submodules with this merge by mistake. Sorry I missed that. Will fix soon...

[xylar]

@hyungyukang, in the future, it would be helpful if Omega branch names always start with omega. This makes updating Polaris later a lot easier.

[hyungyukang]

@hyungyukang, in the future, it would be helpful if Omega branch names always start with omega. This makes updating Polaris later a lot easier.

Sure, I will. Thanks for letting me know.