Skip to content

Removed check for double negative sign in custom format. Replaced by …#2270

Merged
JanKallman merged 6 commits intodevelop8from
fix/customNumberFormat
Feb 4, 2026
Merged

Removed check for double negative sign in custom format. Replaced by …#2270
JanKallman merged 6 commits intodevelop8from
fix/customNumberFormat

Conversation

@AdrianEPPlus
Copy link
Contributor

@AdrianEPPlus AdrianEPPlus commented Feb 2, 2026

…Math.Abs when formatting the string.

Before submitting this pull request I have...

  • read EPPlus Softwares Contribution Guidlines
  • ensured that the functionality I have added/changed is covered by new unit tests.
  • merged the target branch into the PR branch and resolved any merge conflicts
  • Run all the unit tests and ensured that they all are green (unless the purpose of the PR is to provide us with failing unit tests).

@JanKallman JanKallman merged commit fecba85 into develop8 Feb 4, 2026
1 check passed
@JanKallman JanKallman deleted the fix/customNumberFormat branch February 4, 2026 06:46
swmal pushed a commit that referenced this pull request Feb 5, 2026
* WIP:Refactor

* WIP:Fixed errors

* WIP:Fixed more errors

* Fixed broken shape drawing (bounds were not set)

* Fixes issue #2254

* Ugly quick-fix shape theme colors

* Added missing file

* Added theme to base renderItem constructor. Added paragraph default font

* WIP:Fixes for text handling in new implementation

* added corrected fillcolors and paragraph spacing

* Potential solve if string.Concat was the issue (#2256)

* Potential solve if string.Concat was the issue

* Added space

* Fixed first case

* Changed AddText to use DefaultParagraph instead.

* Tried to fix center align. WIP

* Wip:text fixes

* Still two pixels off. Likely Border size

* WIP:Fixed bounding boxes to tranform to inherit from transform

* Merge fix

* Fixed minor spelling mistake

* Adjusted rectangle to not be doubled

* WIP:Fixes for the Svg Textbox in differnet chart objects.

* fixed endgroup for shape + minor misspelling

* removed unimplemented function

* Measurer from > to >= to adjust for round. + test debug

* WIP:Fixes for new positioning system

* Major re-write of line handling

* WIP:Textbox fixes+powerquery metadata

* Fixes issue #2261

* WIP:Textbox

* Broken messy solution

* Added more checks on the ExcelCustomXml.Save method - #2254 (#2264)

* Fixed the major issues. width still wrong after 1st line

* WIP:Work on auto value axis

* Fixes issue #2265 (#2267)

* fixed checking for negative sign when using custom number format. (#2259)

* Functional non-bugged return of textLines

* WIP:Added support for stacked line charts

* Removed check for double negative sign in custom format. Replaced by … (#2270)

* Removed check for double negative sign in custom format. Replaced by Math.Abs when formatting the string.

* Added more tests

* added comment

* Reverted to using regexp

* Added some additional checks for custom format.

* EPPlus version 8.4.2

* Added functional implementation of new system

* Cleanup and starting to add to addtext

* Made it work for charts/regular text

* WIP:Added glow effect for chart objects.

* Fixed test and a few minor bugs

* fixed constructor RunItem now point height

---------

Co-authored-by: Jan Källman <jan.kallman@epplussoftware.com>
Co-authored-by: AdrianEPPlus <162118292+AdrianEPPlus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using second part of the number format, should remove minus and apply the format

2 participants