Glyph-level fallback by Unicode script#2355
Merged
Merged
Conversation
…ed Noto Emoji/Math or named fallback fonts configured via SetScriptFallback. Fixed primary-font FontId invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glyph-level fallback by Unicode script
When a primary font lacks a glyph, EPPlus now routes the lookup based on the code point's Unicode script rather than scanning a fixed fallback list.
Changes
UnicodeScriptenum andUnicodeScriptClassifier(binary search over a sorted range table, O(log n) per code point).DefaultFontProviderrewritten to dispatch by script: Emoji and Math go to the bundled Noto fonts; other scripts (Han, Hiragana, Katakana, Hangul, Arabic, Hebrew, Thai, Devanagari) walk a named fallback chain resolved lazily through the engine.IEpplusFontConfiguration.SetScriptFallback(script, params names)lets users replace any chain. Sensible defaults included for the eight scripts above.DefaultFontProvidernow requires anOpenTypeFontEngineso it can resolve named fallbacks on demand.Bug fix
TextShapernow reservesFontId 0for the primary font on every reset, even when no glyphs come from it.