Skip to content

run s3 zarr tests only if s3 object store is online#2958

Merged
valeriupredoi merged 8 commits intomainfrom
run_s3_tests_only_s3_online
Jan 28, 2026
Merged

run s3 zarr tests only if s3 object store is online#2958
valeriupredoi merged 8 commits intomainfrom
run_s3_tests_only_s3_online

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 27, 2026

Description

I promised @bouweandela I'd take care of this 🍺


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (0680cc4) to head (de37eb4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
- Coverage   95.62%   95.53%   -0.09%     
==========================================
  Files         266      266              
  Lines       15601    15601              
==========================================
- Hits        14918    14904      -14     
- Misses        683      697      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome V! Just the usual nitpicks about code quality 🍻

valeriupredoi and others added 5 commits January 28, 2026 12:04
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@valeriupredoi
Copy link
Contributor Author

Awesome V! Just the usual nitpicks about code quality 🍻

thanks a lot, bud, it's better as you suggested so not nitpicking 😄 I also ruff-ed it, and since today the S3 storage is still offline after JASMIN maintenance, the tests get nicely skipped, and we are minus one headache 🍻

@valeriupredoi valeriupredoi merged commit f07d227 into main Jan 28, 2026
4 checks passed
@valeriupredoi valeriupredoi deleted the run_s3_tests_only_s3_online branch January 28, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants