correction to #2958 - add bucket to S3 url#2959
Merged
valeriupredoi merged 1 commit intomainfrom Jan 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
=======================================
Coverage 95.62% 95.62%
=======================================
Files 266 266
Lines 15601 15601
=======================================
Hits 14918 14918
Misses 683 683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bouweandela
approved these changes
Jan 28, 2026
Contributor
Author
|
thanky @bouweandela 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correction to #2958 - the root of the S3 url will always return a 403 - the actual response test needs be done with the bucket string in the URL, which returns a 200 if online. Sorry @bouweandela my bad, could we get this one in pls? 🍺
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: