Skip to content

correction to #2958 - add bucket to S3 url#2959

Merged
valeriupredoi merged 1 commit intomainfrom
correct_test_s3_url
Jan 28, 2026
Merged

correction to #2958 - add bucket to S3 url#2959
valeriupredoi merged 1 commit intomainfrom
correct_test_s3_url

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 28, 2026

Description

Correction to #2958 - the root of the S3 url will always return a 403 - the actual response test needs be done with the bucket string in the URL, which returns a 200 if online. Sorry @bouweandela my bad, could we get this one in pls? 🍺


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.62%. Comparing base (0680cc4) to head (9687d40).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2959   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files         266      266           
  Lines       15601    15601           
=======================================
  Hits        14918    14918           
  Misses        683      683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valeriupredoi
Copy link
Contributor Author

thanky @bouweandela 🍻

@valeriupredoi valeriupredoi merged commit c4d28ce into main Jan 28, 2026
4 checks passed
@valeriupredoi valeriupredoi deleted the correct_test_s3_url branch January 28, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants