CMIP6 CanESM CMOR fixes for variables with model level coordinates

[k-a-webb]

Description

For variables in the CMIP6 CanESM output which are published on model levels, the coordinate ps has the standard name air_pressure. This causes an issue as the derived pressure level coordinate also has the standard name air_pressure.

For example:

esmvalcore.cmor.check.CMORCheckError: There were errors in variable cli:
 There are multiple coordinates with standard_name "air_pressure": ['ps', None]

The new fix relabels the standard name of ps to surface_air_pressure.

Closes #3164

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[CLAassistant]

All committers have signed the CLA.

[k-a-webb]

@valeriupredoi Would you mind helping me resolve the failed commit fix? I'm lost as to how to handle this.

[malininae]

@k-a-webb and I looked at the code and we've figured out where the issue in tests coming from. Kristi will adjust accordingly and I can act as one of the reviewers.

[malininae]

Looks good to me! I'd say it's ready for review from someone with write permissions.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (c814e65) to head (71f92e2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3165   +/-   ##
=======================================
  Coverage   96.24%   96.25%           
=======================================
  Files         273      274    +1     
  Lines       16172    16189   +17     
=======================================
+ Hits        15565    15582   +17     
  Misses        607      607           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rbeucher]

I don't understand the test logic; none of the classes in Canesm5_1.py are touched by the tests.

[rbeucher]

The tests are not touching the new classes definition in canesm5_1.py

[k-a-webb]

The tests are not touching the new classes definition in canesm5_1.py

We were following the example of https://github.com/ESMValGroup/ESMValCore/blob/canesm_cmor_fixes/esmvalcore/cmor/_fixes/cmip6/mpi_esm1_2_xr.py, which calls all it's classes from mip_esm1_2_hr, and has no explicit test in https://github.com/ESMValGroup/ESMValCore/tree/canesm_cmor_fixes/tests/integration/cmor/_fixes/cmip6

That said, I can generate a near duplicate of test_canesm5.py if that is preferred.

[rbeucher]

I think it's better to have a test_canesm5_1.py Thank you