Skip to content

Fix sic units of HadREM3-GA7-05 with driver ICHEC-EC-EARTH - #3177

Merged
bouweandela merged 3 commits into
mainfrom
fix-hadrem3_ga7_05-sic
Jul 23, 2026
Merged

Fix sic units of HadREM3-GA7-05 with driver ICHEC-EC-EARTH#3177
bouweandela merged 3 commits into
mainfrom
fix-hadrem3_ga7_05-sic

Conversation

@bouweandela

@bouweandela bouweandela commented Jul 22, 2026

Copy link
Copy Markdown
Member

Description

Correct the units of sic from model HadREM3-GA7-05, the NetCDF attribute says the units are in %, but from the values it seems more likely that the units are a fraction.

Follow up to #3135

To test that this works as expected, run this code and observe that the maximum is almost 100%, as expected for data in percent, instead of almost 1%.

In [1]: from esmvalcore.dataset import Dataset

In [2]: Dataset(
   ...:   project="CORDEX",
   ...:   institute="MOHC",
   ...:   dataset="HadREM3-GA7-05",
   ...:   rcm_version="v1",
   ...:   driver="ICHEC-EC-EARTH",
   ...:   domain="EUR-11",
   ...:   mip="day",
   ...:   exp="historical",
   ...:   ensemble="r12i1p1",
   ...:   short_name="sic",
   ...: ).load().lazy_data().max().compute()
Out[2]: np.float32(99.909836)

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label Jul 22, 2026
@bouweandela
bouweandela marked this pull request as ready for review July 22, 2026 12:57
@bouweandela
bouweandela requested review from axel-lauer and ghossh July 22, 2026 13:48

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, buds 🍺

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (f337e40) to head (e30e0c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3177   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         280      280           
  Lines       16246    16248    +2     
=======================================
+ Hits        15661    15663    +2     
  Misses        585      585           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela

Copy link
Copy Markdown
Member Author

Thanks for reviewing!

@bouweandela
bouweandela merged commit d5e9531 into main Jul 23, 2026
5 checks passed
@bouweandela
bouweandela deleted the fix-hadrem3_ga7_05-sic branch July 23, 2026 13:59
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Cordex support (ESO4clima WP2) Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

Development

Successfully merging this pull request may close these issues.

2 participants