Skip to content

Fix KeyInputProc bug#1718

Closed
mateofio wants to merge 1 commit intoEasyRPG:masterfrom
mateofio:keyfix
Closed

Fix KeyInputProc bug#1718
mateofio wants to merge 1 commit intoEasyRPG:masterfrom
mateofio:keyfix

Conversation

@mateofio
Copy link
Copy Markdown
Contributor

Don't set the variable if not waiting.

Fix: #1613

Don't set the variable if not waiting.
@Ghabry
Copy link
Copy Markdown
Member

Ghabry commented Mar 23, 2019

Do you have a minimal test that shows this behaviour?

I did

@> Wait: 0.1 seconds
@> Control Variables: [0001] = 1
@> Key Input Processing: [0001] (Don't wait)

and after the Key Input Variable 1 is 0.

The Wait is just to ensure that no button is buffered

@mateofio
Copy link
Copy Markdown
Contributor Author

I used #1613

I can check again a minimal test tonight

@mateofio
Copy link
Copy Markdown
Contributor Author

You're right

Wait 1.0s
Var1 = 20
Key Input (No Wait) -> Var1
Text \v[1]

Prints 0. So something more subtle is happening in #1613. I will investigate further and change this.

@Ghabry Ghabry added the Needs feedback Waiting for the issue author to give further information. label Mar 26, 2019
@mateofio mateofio closed this Mar 27, 2019
@mateofio
Copy link
Copy Markdown
Contributor Author

This one is totally wrong, so trashed.

@mateofio mateofio deleted the keyfix branch March 27, 2019 00:57
@ghost ghost removed the Needs feedback Waiting for the issue author to give further information. label Mar 27, 2019
@ghost ghost removed this from the 0.6.1 milestone Mar 27, 2019
@ghost ghost added the Invalid label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants