Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyInputProc bug #1718

Closed
wants to merge 1 commit into from

Conversation

@fmatthew5876
Copy link
Contributor

commented Mar 22, 2019

Don't set the variable if not waiting.

Fix: #1613

Fix KeyInputProc bug
Don't set the variable if not waiting.
@Ghabry

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Do you have a minimal test that shows this behaviour?

I did

@> Wait: 0.1 seconds
@> Control Variables: [0001] = 1
@> Key Input Processing: [0001] (Don't wait)

and after the Key Input Variable 1 is 0.

The Wait is just to ensure that no button is buffered

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

I used #1613

I can check again a minimal test tonight

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

You're right

Wait 1.0s
Var1 = 20
Key Input (No Wait) -> Var1
Text \v[1]

Prints 0. So something more subtle is happening in #1613. I will investigate further and change this.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

This one is totally wrong, so trashed.

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:keyfix branch Mar 27, 2019

@fdelapena fdelapena removed this from the 0.6.1 milestone Mar 27, 2019

@fdelapena fdelapena added the Invalid label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.