Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

fix: link and linkstats relationship#7913

Merged
eddiejaoude merged 1 commit intomainfrom
fix-link-stats-relatioship
Jul 2, 2023
Merged

fix: link and linkstats relationship#7913
eddiejaoude merged 1 commit intomainfrom
fix-link-stats-relatioship

Conversation

@eddiejaoude
Copy link
Copy Markdown
Member

Fixes Issue

The relationship should be one sided because

  • it will grow large in the profile
  • we will never do a join but query the stats model directly

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions Bot added medium Pull request with changed lines between 10 and 30 waiting-for-reviewers labels Jul 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2023

Reviewpad Report

ℹ️ Messages

  • A maintainer will review your pull request soon!

@eddiejaoude eddiejaoude merged commit 1d33148 into main Jul 2, 2023
@eddiejaoude eddiejaoude deleted the fix-link-stats-relatioship branch July 2, 2023 03:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

medium Pull request with changed lines between 10 and 30 waiting-for-reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant