Secure MSSQL transport defaults - #6766
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d923788 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Changed MSSQL transport defaults from insecure to secure —
encryptnow defaults totrue(TLS encryption on) andtrustServerCertificatenow defaults tofalse(certificate validation on), with JSDoc warnings about the risks of disabling either protection. - Added mocked regression tests —
TransportConfig.test.tsverifies both secure defaults and explicit insecure overrides using a vitest-mockedtediousmodule. - Added breaking-change changeset — documents the migration path for users connecting to instances without TLS or with self-signed certificates.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
enabled auto-merge (squash)
July 30, 2026 00:04
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Removed
TransportConfig.test.ts— the mocked transport-configuration test was deleted. The coreMssqlClient.tschanges (JSDoc additions andencrypt/trustServerCertificatedefault flips) and the breaking changeset remain unchanged from the prior review.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm lint-fixpnpm checkpnpm --filter @effect/sql-mssql test --run --maxConcurrency 1(16 tests pass)The default package-wide concurrent run also exposes a pre-existing shared-state race in
SqlErrorClassification.test.ts; those tests pass when run serially.Closes EFF-212