Skip to content

Secure MSSQL transport defaults #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-smart merged 2 commits into from
Jul 30, 2026
+15 −2
Merged

Secure MSSQL transport defaults #6766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce0414
Secure MSSQL transport defaults
tim-smart Jul 29, 2026
d923788
Delete packages/sql/mssql/test/TransportConfig.test.ts
tim-smart Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/eff-212-secure-mssql-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@effect/sql-mssql": patch
---

**Breaking:** Secure Microsoft SQL Server connections by default by enabling encryption and validating server certificates.

Users connecting to SQL Server instances without TLS must now explicitly set `encrypt: false`. Users connecting with untrusted or self-signed certificates must explicitly set `trustServer: true`.
10 changes: 8 additions & 2 deletions packages/sql/mssql/src/MssqlClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,13 @@ export interface MssqlClientConfig {
readonly domain?: string | undefined
readonly server: string
readonly instanceName?: string | undefined
/**
* Whether to encrypt traffic between the client and server. Defaults to `true`. Setting this to `false` disables transport encryption and transmits credentials in cleartext.
*/
readonly encrypt?: boolean | undefined
/**
* Whether to trust the server certificate without validating it. Defaults to `false`. Setting this to `true` disables TLS certificate validation.
*/
readonly trustServer?: boolean | undefined
readonly port?: number | undefined
readonly authType?: string | undefined
Expand Down Expand Up @@ -284,15 +290,15 @@ export const make = (
options: {
port: options.port,
database: options.database,
trustServerCertificate: options.trustServer ?? true,
trustServerCertificate: options.trustServer ?? false,
multiSubnetFailover: options.multiSubnetFailover,
connectTimeout: options.connectTimeout
? Duration.toMillis(Duration.fromInputUnsafe(options.connectTimeout))
: undefined,
rowCollectionOnRequestCompletion: true,
useColumnNames: false,
instanceName: options.instanceName,
encrypt: options.encrypt ?? false,
encrypt: options.encrypt ?? true,
cancelTimeout: options.cancelTimeout
? Duration.toMillis(Duration.fromInputUnsafe(options.cancelTimeout))
: undefined,
Expand Down
Loading