Fix SubscriptionRef getAndUpdateSome None result - #6849
Merged
Conversation
🦋 Changeset detectedLatest commit: f1607ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Reproduction test for
getAndUpdateSomeNone branch bug — adds a test that callsgetAndUpdateSomewith() => Option.none()and asserts the previous value is returned as1. The test correctly reproduces the bug where theNonebranch atpackages/effect/src/SubscriptionRef.ts:377returnsEffect.succeed(current)instead ofcurrent, causing a nestedEffectto leak out.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
changed the title
effect-slopcop
Bot
added
3.0
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Fixed
getAndUpdateSomeNone-branch return — changedreturn Effect.succeed(current)toreturn currentatpackages/effect/src/SubscriptionRef.ts:377, matching the pattern of all other*Some*functions in the file. The reproduction test now passes. - Added changeset — patch-level release note for the bug fix.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionRef.getAndUpdateSomeOption.noneselects no updateCovered audit issue
1.
core-s-z-testing-subscription-ref-nested-effect: getAndUpdateSome returns a nested Effect on NoneModule:
SubscriptionRefExpected contract: getAndUpdateSome returns the old A whether the update is Option.some or Option.none.
Observed result: success Exit object instead of 1
Reproduction command:
Closes EFF-293