Fix SubscriptionRef getAndUpdateSome None result

.changeset/fix-subscription-ref-get-and-update-some.md

@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Fix `SubscriptionRef.getAndUpdateSome` to return the current value when no update is selected.

packages/effect/src/SubscriptionRef.ts

@@ -374,7 +374,7 @@ export const getAndUpdateSome: {
     const current = self.value
     const option = update(current)
     if (Option.isNone(option)) {
-      return Effect.succeed(current)
+      return current
     }
     setUnsafe(self, option.value)
     return current

packages/effect/test/SubscriptionRef.test.ts

@@ -1,5 +1,5 @@
 import { assert, describe, it } from "@effect/vitest"
-import { Array, Effect, Exit, Fiber, Latch, Number, Pull, Random, Stream, SubscriptionRef } from "effect"
+import { Array, Effect, Exit, Fiber, Latch, Number, Option, Pull, Random, Stream, SubscriptionRef } from "effect"
 
 describe("SubscriptionRef", () => {
   it.effect("isSubscriptionRef", () =>
@@ -17,6 +17,14 @@ describe("SubscriptionRef", () => {
       assert.strictEqual(yield* SubscriptionRef.get(ref), 2)
     }))
 
+  it.effect("getAndUpdateSome returns the current value when no update is selected", () =>
+    Effect.gen(function*() {
+      const ref = yield* SubscriptionRef.make(1)
+      const previous = yield* SubscriptionRef.getAndUpdateSome(ref, () => Option.none())
+
+      assert.strictEqual(previous, 1)
+    }))
+
   it.effect("multiple subscribers can receive changes", () =>
     Effect.gen(function*() {
       const ref = yield* SubscriptionRef.make(0)