Add reproduction for TxQueue issue - #6853
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a8fad6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
offerAll preserves a one-shot iterable across retries— adds a reproduction test that demonstratesTxQueue.offerAllloses items from one-shot generators when the bounded queue is full and the STM retries, re-exhausting the iterable.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
reviewed
Aug 2, 2026
| Effect.gen(function*() { | ||
| const rejected: Array<A> = [] | ||
| Effect.suspend(() => { | ||
| const valuesArray = Array.from(values) |
Contributor
There was a problem hiding this comment.
This should be materialized outside of the effect so it is re-usable between seperate runs.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Iterable materialization in
TxQueue.offerAll— wrappedArray.from(values)inEffect.suspendso one-shot iterables are consumed once before enteringEffect.tx, preventing STM retries from re-exhausting the generator. - Test synchronization — replaced the
iterationscounter plus busy-waityieldNowloop with aLatch, giving deterministic coordination between the forkedofferAlland the parent test.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
enabled auto-merge (squash)
August 2, 2026 23:02
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Removed
Effect.suspend, materialized iterable at function scope —Array.from(values)now runs atofferAllcall time (line 612), before any effect tree, so the captured array survives both STM retries and repeated effect runs. - Test now covers effect reuse — the test runs the returned
offereffect a second time and verifies the same captured item is produced, plus replacedLatchsynchronization with{ startImmediately: true }for deterministic execution.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TxQueue.offerAllto materialize input iterables outside the effectTesting
Closes EFF-295