Add reproduction for TxQueue issue

.changeset/fix-txqueue-offer-all-iterables.md

@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Fix `TxQueue.offerAll` to preserve one-shot iterables across transaction retries and repeated runs.

packages/effect/src/TxQueue.ts

@@ -608,11 +608,13 @@ export const offerAll: {
   <A, E>(self: TxEnqueue<A, E>, values: Iterable<A>): Effect.Effect<Array<A>>
 } = dual(
   2,
-  <A, E>(self: TxEnqueue<A, E>, values: Iterable<A>): Effect.Effect<Array<A>> =>
-    Effect.gen(function*() {
+  <A, E>(self: TxEnqueue<A, E>, values: Iterable<A>): Effect.Effect<Array<A>> => {
+    const valuesArray = Array.from(values)
+
+    return Effect.gen(function*() {
       const rejected: Array<A> = []
 
-      for (const value of values) {
+      for (const value of valuesArray) {
         const accepted = yield* offer(self, value)
         if (!accepted) {
           rejected.push(value)
@@ -621,6 +623,7 @@ export const offerAll: {
 
       return rejected
     }).pipe(Effect.tx)
+  }
 )
 
 /**

packages/effect/test/TxQueue.test.ts

@@ -230,6 +230,25 @@ describe("TxQueue", () => {
         assert.strictEqual(size, 5)
       })))
 
+    it.effect("offerAll preserves a one-shot iterable across retries and runs", () =>
+      Effect.gen(function*() {
+        const queue = yield* TxQueue.bounded<number>(1)
+        yield* TxQueue.offer(queue, 1)
+
+        const values = (function*() {
+          yield 2
+        })()
+        const offer = TxQueue.offerAll(queue, values)
+        const fiber = yield* Effect.forkChild(offer, { startImmediately: true })
+
+        assert.strictEqual(yield* TxQueue.take(queue), 1)
+        assert.deepStrictEqual(yield* Fiber.join(fiber), [])
+        assert.deepStrictEqual(yield* TxQueue.poll(queue), Option.some(2))
+
+        assert.deepStrictEqual(yield* offer, [])
+        assert.deepStrictEqual(yield* TxQueue.poll(queue), Option.some(2))
+      }))
+
     it.effect("takeAll works correctly with new signature", () =>
       Effect.tx(Effect.gen(function*() {
         const queue = yield* TxQueue.bounded<number>(10)