Prevent Effect.provideServiceEffect supertype widening - #7025
Merged
tim-smart merged 1 commit intoAug 5, 2026
Merged
Conversation
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues — one suggestion to round out the new type test.
Reviewed changes
packages/effect/src/Effect.ts: addedNoInfer<S>to theacquireparameter of bothprovideServiceEffectoverloads so the acquisition effect can no longer widen the inferred service type.packages/effect/typetest/Effect.tst.ts: added a type-level regression test using a literal service type and@ts-expect-errorfor anEffect<string, never, never>acquisition..changeset/loose-wings-lie.md: added a patch changeset foreffect.
The fix is consistent with the existing Layer.effect overload, which already uses Types.NoInfer<S> for the same reason. I ran pnpm test-types packages/effect/typetest/Effect.tst.ts and the new test passes (206 tests, 314 assertions).
@v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
pawelblaszczyk5
force-pushed
the
effect-provide-service-effect-no-infer
branch
from
August 5, 2026 09:50
7c756f7 to
c024757
Compare
🦋 Changeset detectedLatest commit: c024757 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Added a data-first type test in
packages/effect/typetest/Effect.tst.tsto cover bothprovideServiceEffectoverloads, addressing the prior review feedback. - The
NoInfer<S>signature change inpackages/effect/src/Effect.tsand the patch changeset remain unchanged.
@v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
tim-smart
approved these changes
Aug 5, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Currently
Effect.provideServiceEffectacquire Effect is also used for inferring generic of provided service value. This makes returning supertype from Effect pass type checking. I discovered this in my own project where I've added new field to Context.Service and it didn't catch any issues despite it not being properly provided.To fix this I added NoInfer marker to acquire effect to make sure that it isn't constituting to inferred type. I added type level test, which correctly fails without this PR change:
Related
N/A