Prevent Effect.updateService and Effect.updateServiceScoped supertype widening - #7027
Merged
tim-smart merged 1 commit intoAug 5, 2026
Conversation
🦋 Changeset detectedLatest commit: d50993d The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pawelblaszczyk5
force-pushed
the
additional-service-effect-supertype
branch
from
August 5, 2026 13:42
30ad40e to
d50993d
Compare
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
packages/effect/src/Effect.ts: AddedNoInfer<A>to the return type of the updater function inEffect.updateService(both overloads) andEffect.updateServiceScoped, preventing TypeScript from widening the inferred service type via the updater return value.packages/effect/typetest/Effect.tst.ts: Added three TSTyche type tests that assert returning a supertype (string) from the updater is rejected for a literal service ("LITERAL")..changeset/funny-ears-beam.md: Added a patch changeset foreffect.
This is a narrow, type-only fix analogous to #7025. The runtime implementation in internal/effect.ts is unchanged and correct; only the public type signatures are tightened.
@v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Analogous to #7025 - some additional methods related to services that I've spotted.
Added tests failing without these changes:
Related
#7025