Issue
Description
After discussing with @benaloh , there were notes that ballot chaining should not be required. This being said, the module doesn't really require it as much as imply it. There are some easy locations to fix this.
-
The use of previous_code could merely be code_seed since that is actually what it is. This would of course ripple to any of the usage.
https://github.com/microsoft/electionguard-python/blob/355b587ea9c4e80c9228183e5c2da68bc40f2afa/src/electionguard/ballot.py#L669
-
This get_roating_ballot_code is a bit of a misnomer of a method. Truly this is just a hash of the ballot_code. This could likely be moved and changed simply to just get_ballot_code. Open to opinions on this.
https://github.com/microsoft/electionguard-python/blob/355b587ea9c4e80c9228183e5c2da68bc40f2afa/src/electionguard/ballot_code.py#L17
Issue
Description
After discussing with @benaloh , there were notes that ballot chaining should not be required. This being said, the module doesn't really require it as much as imply it. There are some easy locations to fix this.
The use of
previous_codecould merely becode_seedsince that is actually what it is. This would of course ripple to any of the usage.https://github.com/microsoft/electionguard-python/blob/355b587ea9c4e80c9228183e5c2da68bc40f2afa/src/electionguard/ballot.py#L669
This
get_roating_ballot_codeis a bit of a misnomer of a method. Truly this is just ahashof theballot_code. This could likely be moved and changed simply to justget_ballot_code. Open to opinions on this.https://github.com/microsoft/electionguard-python/blob/355b587ea9c4e80c9228183e5c2da68bc40f2afa/src/electionguard/ballot_code.py#L17