Fix Issue #347: Remove wording that implies ballot chaining#348
Merged
keithrfung merged 7 commits intomainfrom Mar 29, 2021
unknown repository
Merged
Fix Issue #347: Remove wording that implies ballot chaining#348keithrfung merged 7 commits intomainfrom unknown repository
keithrfung merged 7 commits intomainfrom
unknown repository
Conversation
|
|
Author
|
PTAL |
keithrfung
suggested changes
Mar 25, 2021
Contributor
keithrfung
left a comment
keithrfung
left a comment
There was a problem hiding this comment.
Wow. Great work! Only a couple of changes which should be pretty light.
| :param contests: List of contests for this ballot | ||
| :param timestamp: Timestamp at which the ballot encryption is generated in tick | ||
| :param previous_code: Previous ballot code or seed | ||
| :param code_seed: Previous ballot code or seed |
Contributor
There was a problem hiding this comment.
The descriptions should be changed as well. This one should be Seed for ballot code
| @@ -877,9 +877,7 @@ def make_ciphertext_ballot( | |||
| if previous_ballot_code is None: | |||
Contributor
There was a problem hiding this comment.
This linen should also be code_seed.
I would do a search for previous_ballot_code
Contributor
|
Apologies for the late review. Been one of those weeks |
ghost
requested a review
from
keithrfung
approved these changes
Mar 29, 2021
This was referenced Mar 29, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Please review the guidelines for contributing to this repository.
Issue
Fixes issue #347
Description
Renamed
get_rotating_ballot_codetoget_ballot_codeandprevious_codetocode_seed