Fix/discrete log async#131
Merged
keithrfung merged 2 commits intomainfrom Aug 5, 2020
Merged
Conversation
Collaborator
Author
|
Need to rebase this before merge. The change here is way too big. |
c4e9234 to
a565e1e
Compare
Collaborator
Author
|
Okay, rebase successful. The PR now only touches |
keithrfung
reviewed
Aug 4, 2020
keithrfung
reviewed
Aug 4, 2020
keithrfung
suggested changes
Aug 4, 2020
Contributor
keithrfung
left a comment
There was a problem hiding this comment.
Changed this to ready for review and left comments since this seemed as if the changes were already implemented.
9 tasks
Contributor
|
modified the comment lines to be more concise in code, and moved the description into the PR. Everything is ready to go |
keithrfung
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #130
Description
I'm working on getting EG to work with ray.io, a cluster computing framework. I ran into one issue with async code in dlog.py. The gist of it is that the call to initialize __dlog_lock was failing, and I was getting an error about a missing "event loop". Turns out, the way Ray was running the code was tickling this issue.
The solution is really straightforward: delay initialization of the lock variable until you're inside __discrete_log_internal.
Testing
The existing test suite still works fine.
Checklist
🚨Please review the guidelines for contributing to this repository.
💚Thank you!