Skip to content

Temporary fix branch related to three PRs#136

Closed
danwallach wants to merge 7 commits intomainfrom
temporary/omnibus-fixes
Closed

Temporary fix branch related to three PRs#136
danwallach wants to merge 7 commits intomainfrom
temporary/omnibus-fixes

Conversation

@danwallach
Copy link
Copy Markdown
Collaborator

Issue

Related to issues: #120, #122, #126, #130, #132
This temporary branch merges three PRs: #131, #133, #135

DO NOT MERGE.

Description

I need a single branch that I can point arlo-e2e to use that has fixes for the listed issues. This branch only exists until those PRs land, then we can get rid of it.

Testing

This branch is a merge of three PRs, and passes all tests, but do not merge it.

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • DO check open PR's to avoid duplicates.
  • DO keep pull requests small so they can be easily reviewed.
  • DO build locally before pushing.
  • DO make sure tests pass.
  • DO make sure any new changes are documented.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

💚Thank you!

@keithrfung keithrfung closed this Aug 5, 2020
@keithrfung keithrfung deleted the temporary/omnibus-fixes branch September 22, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants