Bug/cleanup output data #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add scheduler singleton to handle creating pools an closing pools. - Remove Pool references and replace scheduler - Update tests and benchmarks
add tally methods to tally in batches
…eature/multi-processing
also, fix a bug where the tally did not include the decryption shares, and where a few of the CP proofs were not using the crypto_extended_base_hash in their challenge inputs
|
This pull request introduces 5 alerts when merging d363a51 into 463bf0c - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging 9d6f6e2 into 463bf0c - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 28df5ff into 463bf0c - view on LGTM.com new alerts:
|
…ug/cleanup-output-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Link your PR to an issue
Fixes #137
Description
Use friendly variable names for proofs. add comments to them to make it easy to find in the spec. Add the decryption shares to the tally output. Fix a bug with the CP proofs were a couple of them were not using the extended base hash code as an input to the challenge generators. Added challenge values explicitly in a few places to ease computational comparisons
depends on: #134
Testing
Checklist
🚨Please review the guidelines for contributing to this repository.
💚Thank you!