Refactor ElectionDescription to Manifest#337
Merged
keithrfung merged 5 commits intomainfrom Mar 8, 2021
Merged
Conversation
keithrfung
force-pushed
the
fix/refactor-election-description
branch
from
dac01eb to
b3620a6
Compare
AddressXception
previously approved these changes
Mar 5, 2021
Contributor
AddressXception
left a comment
AddressXception
left a comment
There was a problem hiding this comment.
this reads much better
- Move the files to a manifest file - Keep election as just context and constants
- Add manifest tests - Refactor all the old tests. - Update the usage of words from description to manifest
keithrfung
force-pushed
the
fix/refactor-election-description
branch
from
780f406 to
2e5893c
Compare
AddressXception
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Please review the guidelines for contributing to this repository.
Issue
Fixes #327
Description
electionwhen it was truly amanifestTesting
Existing test suite. Tests moved but not changed beyond naming