Skip to content

Fix/refactor tracker#165

Merged
AddressXception merged 13 commits intomainfrom
fix/refactor-tracker
Apr 6, 2021
Merged

Fix/refactor tracker#165
AddressXception merged 13 commits intomainfrom
fix/refactor-tracker

Conversation

@AddressXception
Copy link
Copy Markdown
Contributor

@AddressXception AddressXception commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

@keithrfung keithrfung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most notable fix is InternalElectionDescription reference, but a couple other small things.

Comment thread bindings/netstandard/ElectionGuard/ElectionGuard.Shared/Encrypt.cs Outdated
Comment thread bindings/netstandard/ElectionGuard/ElectionGuard.Shared/Encrypt.cs Outdated
Comment thread bindings/netstandard/ElectionGuard/ElectionGuard.Shared/NativeInterface.cs Outdated
Comment thread bindings/netstandard/ElectionGuard/ElectionGuard.Shared/NativeInterface.cs Outdated
Comment thread bindings/netstandard/ElectionGuard/ElectionGuard.Shared/NativeInterface.cs Outdated
Comment thread src/electionguard/facades/ballot_code.cpp Outdated
Comment thread src/electionguard/facades/encrypt.cpp Outdated
Comment thread src/electionguard/facades/encrypt.cpp Outdated
Comment thread test/electionguard/mocks/words.cpp Outdated
Comment thread test/electionguard/test_words.cpp Outdated
@AddressXception AddressXception marked this pull request as draft March 31, 2021 19:42
@AddressXception AddressXception marked this pull request as ready for review April 2, 2021 18:09
@keithrfung keithrfung self-requested a review April 2, 2021 20:52
@AddressXception AddressXception merged commit 0a6c535 into main Apr 6, 2021
@AddressXception AddressXception deleted the fix/refactor-tracker branch April 30, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor type and parameter names to match python

3 participants