Decryption Mediator Rework#353
Merged
keithrfung merged 7 commits intointegration/stateful-refactorfrom Apr 19, 2021
Merged
Conversation
keithrfung
force-pushed
the
feature/decryption-mediator
branch
3 times, most recently
from
86c9c4d to
7db39f6
Compare
|
This pull request introduces 2 alerts when merging 7db39f6 into f0659eb - view on LGTM.com new alerts:
|
keithrfung
force-pushed
the
feature/decryption-mediator
branch
from
7db39f6 to
c2f8c60
Compare
|
This pull request introduces 3 alerts when merging c2f8c60 into f0659eb - view on LGTM.com new alerts:
|
Replace methods for simpler single ballot methods that can then be iterated through. This reduces down the scope and gives individuals more flexibility on collections without the use of DataStore
Create a decryption helper to assist in explaining how to perform the decryption ceremony without the repeated code in various sections
To reduce the amount of typing here and replace with a singular name instead of adding extra types to exports
Guardian is now in charge of its own shares and uses the functional methods instead of referencing some internal methods. A guardian must perform their own shares and send to mediator
Major change to decryption mediator. The mediator now only handles the brief exchanges of shares and reconstructs the missing guardian shares. Missing guardians now also have to be announced separately. Other tests updated to match.
keithrfung
force-pushed
the
feature/decryption-mediator
branch
from
c2f8c60 to
72fa0fe
Compare
AddressXception
approved these changes
Apr 16, 2021
Closed
keithrfung
added a commit
that referenced
this pull request
Apr 20, 2021
* ♻️ Add MEDIATOR_ID type * 🔥 Remove methods forcing multiplicity on ballots Replace methods for simpler single ballot methods that can then be iterated through. This reduces down the scope and gives individuals more flexibility on collections without the use of DataStore *⚠️ Create a Decryption Helper Create a decryption helper to assist in explaining how to perform the decryption ceremony without the repeated code in various sections * ♻️ Remove available / missing name To reduce the amount of typing here and replace with a singular name instead of adding extra types to exports * ✅ Update decryption test for a single ballot * ✨ Update Guardian to perform own shares Guardian is now in charge of its own shares and uses the functional methods instead of referencing some internal methods. A guardian must perform their own shares and send to mediator * ✨ Update Decryption Mediator Major change to decryption mediator. The mediator now only handles the brief exchanges of shares and reconstructs the missing guardian shares. Missing guardians now also have to be announced separately. Other tests updated to match.
keithrfung
added a commit
that referenced
this pull request
Apr 21, 2021
* ♻️ Add MEDIATOR_ID type * 🔥 Remove methods forcing multiplicity on ballots Replace methods for simpler single ballot methods that can then be iterated through. This reduces down the scope and gives individuals more flexibility on collections without the use of DataStore *⚠️ Create a Decryption Helper Create a decryption helper to assist in explaining how to perform the decryption ceremony without the repeated code in various sections * ♻️ Remove available / missing name To reduce the amount of typing here and replace with a singular name instead of adding extra types to exports * ✅ Update decryption test for a single ballot * ✨ Update Guardian to perform own shares Guardian is now in charge of its own shares and uses the functional methods instead of referencing some internal methods. A guardian must perform their own shares and send to mediator * ✨ Update Decryption Mediator Major change to decryption mediator. The mediator now only handles the brief exchanges of shares and reconstructs the missing guardian shares. Missing guardians now also have to be announced separately. Other tests updated to match. Remove commented lines
keithrfung
added a commit
that referenced
this pull request
Apr 21, 2021
* ♻️ Add MEDIATOR_ID type * 🔥 Remove methods forcing multiplicity on ballots Replace methods for simpler single ballot methods that can then be iterated through. This reduces down the scope and gives individuals more flexibility on collections without the use of DataStore *⚠️ Create a Decryption Helper Create a decryption helper to assist in explaining how to perform the decryption ceremony without the repeated code in various sections * ♻️ Remove available / missing name To reduce the amount of typing here and replace with a singular name instead of adding extra types to exports * ✅ Update decryption test for a single ballot * ✨ Update Guardian to perform own shares Guardian is now in charge of its own shares and uses the functional methods instead of referencing some internal methods. A guardian must perform their own shares and send to mediator * ✨ Update Decryption Mediator Major change to decryption mediator. The mediator now only handles the brief exchanges of shares and reconstructs the missing guardian shares. Missing guardians now also have to be announced separately. Other tests updated to match. Remove commented lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Please review the guidelines for contributing to this repository.
Issue
Fixes #354
Description
This is the removal of the the guardians from being within the Decryption Mediator.
MEDIATOR_IDtypeballots(multiple) in favor of onlyballots(singular) methodsAVAILABLE_GUARDIAN_IDandMISSING_GUARDIAN_IDto reduce exportsTesting
The existing test suite had to be modified but the test coverage should showcase the changes.
end_to_end and decryption tests should be focused on.