Stateful Refactor#356
Merged
keithrfung merged 2 commits intomainfrom Apr 21, 2021
Merged
Conversation
This was
linked to
issues
Apr 20, 2021
Closed
Closed
keithrfung
force-pushed
the
integration/stateful-refactor
branch
from
e11bf37 to
7597478
Compare
| self.context, | ||
| self.ciphertext_tally, | ||
| self.ciphertext_ballots, | ||
| # self.ciphertext_tally, |
Contributor
There was a problem hiding this comment.
we leaving this commented out for a reason?
Contributor
Author
There was a problem hiding this comment.
Nope. this is a mistake. Good catch.
AddressXception
previously approved these changes
Apr 21, 2021
* 🐛. Exponent modifier should not be zero The exponent modifier should never be allowed to be zero to compute a polynomial coordinate. In the same way a sequence_order should never be zero. * Refactor Auxiliary Key * Refactor Elgamal Key * Refactor ElectionPolynomial * Refactor Key Ceremony and Election Keys - Remove GuardianKeyPair for migration to stateful class - Migration of coefficient commitments and proofs into electionpublickey - Removal of hash coefficient commitment specialty method - Update tests * Update Publish and tests * Update Guardian to Stateless * Functional Key Ceremony Test * Update Decryption * ❓Remove optional on store Optional on store shouldn't exist. This returns a list. * Refactor Guardian - Remove references to manually doing recovery key - Ensure using new naming for election public key - Correctly handle publish - Change tests to rely on what can possibly be an outside verifier not necessarily a guardian. * Refactor Key Ceremony - Ensure key owner id and sequence order passed into all guardian key generation * Implement Key Ceremony Helper Key Ceremony Helper is both an example and a test implementation to perform the key ceremony. The idea is to provide an example and simply long testing sections. * Updates to Functional Key Ceremony * Add identity encrypt to ElectionGuard Test Identity encrypt to the mock library to reduce the recoding of this function * Update decryption tests * Update Election Builder * Update Key Ceremony Mediator * Add Changes into Election Factory * Update Decryption Mediator * Update End to End Election Tests Update the end to end election to demonstrate the entire election process including the new key ceremony changes. * Review Adjustments - Add property descriptions - Add method descriptions * Remove sequence order that is created with zero * Update Ballot Box to use BALLOT_ID * 🐛 Fix decryption mediator for ballots * ✅ Add Decryption Tests - Migrate some tests to decrypt_with_shares - Add test_decryption tests - Add Decryption Mediator tests
* ♻️ Add MEDIATOR_ID type * 🔥 Remove methods forcing multiplicity on ballots Replace methods for simpler single ballot methods that can then be iterated through. This reduces down the scope and gives individuals more flexibility on collections without the use of DataStore *⚠️ Create a Decryption Helper Create a decryption helper to assist in explaining how to perform the decryption ceremony without the repeated code in various sections * ♻️ Remove available / missing name To reduce the amount of typing here and replace with a singular name instead of adding extra types to exports * ✅ Update decryption test for a single ballot * ✨ Update Guardian to perform own shares Guardian is now in charge of its own shares and uses the functional methods instead of referencing some internal methods. A guardian must perform their own shares and send to mediator * ✨ Update Decryption Mediator Major change to decryption mediator. The mediator now only handles the brief exchanges of shares and reconstructs the missing guardian shares. Missing guardians now also have to be announced separately. Other tests updated to match. Remove commented lines
keithrfung
force-pushed
the
integration/stateful-refactor
branch
from
7597478 to
b3251d4
Compare
AddressXception
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Please review the guidelines for contributing to this repository.
Issue
Fixes #335
Fixes #354
Fixes #346
Fixes #220
Fixes #340
Description
This is a combination of two major parts of work.
The first part is refactoring the Key Ceremony to not use Guardians at any stage and focus on the ElectionPublicKey
The second part is refactoring the Decryption process to also isolate the guardians at any stage and focus on passing of the shares
MUST BE REBASED AND MERGED