Support supplying contract hash to issueasset RPC - #1010
Merged
apoelstra merged 1 commit intoSep 16, 2021
Conversation
stevenroose
force-pushed
the
fw-issue-asset-contract-hash
branch
from
July 28, 2021 14:32
d856472 to
b8deedc
Compare
Member
|
Can you rebase this and see if that fixes CI |
stevenroose
force-pushed
the
fw-issue-asset-contract-hash
branch
from
September 8, 2021 13:08
b8deedc to
2bcaeb2
Compare
Contributor
Author
|
Done |
Member
|
Looks like you added an option to the RPC help but didn't add it again to the list of RPCs at the bottom of wallet/rpcwallet.cpp. This redundancy will be removed in 22.0 but in 0.21 we just enforce consistency in CI. |
stevenroose
force-pushed
the
fw-issue-asset-contract-hash
branch
from
September 15, 2021 17:23
2bcaeb2 to
47d43f1
Compare
Contributor
Author
|
I added that, sorry |
Contributor
Author
|
Somehow CI doesn't seem to run on this one.. Does anyone understand why that is? |
Member
|
It looks like it ran and all the checks passed. |
apoelstra
approved these changes
Sep 16, 2021
gwillen
pushed a commit
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forward port of #993.
Closes #985.