Fix interface_zmq.py functional tests - #1590
Merged
Merged
Conversation
tomt1664
marked this pull request as draft
August 28, 2026 00:50
…tform fix is_valid() in test framework for elements amounts
tomt1664
force-pushed
the
fix_multi_commit
branch
2 times, most recently
from
September 1, 2026 11:03
176ab79 to
665d873
Compare
tomt1664
changed the title
tomt1664
marked this pull request as ready for review
September 1, 2026 12:01
delta1
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the test-each-commit CI job:
Broaden the CMake guard from if(APPLE) to also match Clang on any platform, e.g. if(CMAKE_C_COMPILER_ID MATCHES "Clang") (this covers both Clang and AppleClang) for the elementssimplicity compilation.
Fix is_valid() in test framework for elements amounts, enabling interface_zmq.py to pass.