Untested: Rpc call for per-block fee statistics#178
Closed
jtimon wants to merge 3 commits intoElementsProject:elements-0.13.1from
Closed
Untested: Rpc call for per-block fee statistics#178jtimon wants to merge 3 commits intoElementsProject:elements-0.13.1from
jtimon wants to merge 3 commits intoElementsProject:elements-0.13.1from
Conversation
Contributor
|
Is there an associated issue with this? |
Contributor
Author
|
No, it's just a proposed new feature. In Bitcoin Core this would be much more complicated, but since CT needs explicit fees anyway, it is pretty simple to do it here. |
Contributor
Author
|
squashed for clarity |
It requires CT because otherwise fees aren't explicit
Contributor
Author
|
A more correct version (with corrections after writting the tests) is in #185 for 0.14 instead of 0.13. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still need to test it and squash, and there's one TODO, but review welcomed already.