Skip to content

Rpc: Introduce call for per-block fee statistics#185

Merged
instagibbs merged 4 commits intoElementsProject:elements-0.14.1from
jtimon:e14-rpc-plotter
May 16, 2018
Merged

Rpc: Introduce call for per-block fee statistics#185
instagibbs merged 4 commits intoElementsProject:elements-0.14.1from
jtimon:e14-rpc-plotter

Conversation

@jtimon
Copy link
Copy Markdown
Contributor

@jtimon jtimon commented Jun 21, 2017 •
edited
Loading

EDIT: Don't merge until bitcoin/bitcoin#10757 is resolved (please, review that first)

New feature. In Bitcoin Core this would be much more complicated, but since CT needs explicit fees anyway, it is pretty simple to do it here.
The idea is to generate data to plot.

Replaces #178 (which was incomplete and based on 0.13 instead of 0.14).

@jtimon jtimon mentioned this pull request Jun 21, 2017
Closed
@jtimon jtimon force-pushed the e14-rpc-plotter branch 3 times, most recently from cd9f4e5 to b39205d Compare June 21, 2017 21:24
@jtimon jtimon mentioned this pull request Jun 22, 2017
Merged
@jtimon jtimon force-pushed the e14-rpc-plotter branch from b39205d to e402f26 Compare June 22, 2017 01:32
@jtimon
Copy link
Copy Markdown
Contributor Author

jtimon commented Jul 6, 2017 •
edited
Loading

Upstreamed as bitcoin/bitcoin#10757

@jtimon
Copy link
Copy Markdown
Contributor Author

jtimon commented Jul 7, 2017

With respect to bitcoin/bitcoin#10757 this adds an asset optional parameter to the call that is not tested, the tests assume the default policyAsset is used for everything.
If not for fees, perhaps it would be nice to show charts for per-asset total amounts publicly moved, total number of txs involving a public use of an asset, opting out of the CA feature, even if you hide the amounts, ins, outs, number of public keys involved per block per asset, I bet other people can find more creative ways to chart inadvisable things as "public" than just using "the null nounce" for your CA txs just to show off on these "you shouldn't be doing this per-public-asset" charts.
I guess the same trick "null nounce" trick could apply to CT txs, and there's also public amounts without CT, and we could maybe plot the different combinations and their effect for some heuristics for "privacy" (I can't write that function, or those functions), and maybe the privacy/weight ratio too.

Anyway, future work...

@jtimon jtimon changed the title Rpc: Introduce call for per-block fee statistics NOMERGE: Rpc: Introduce call for per-block fee statistics Aug 26, 2017
@jtimon
Copy link
Copy Markdown
Contributor Author

jtimon commented Aug 26, 2017

Rebased just to get travis and one fix related to building without wallet in particular documented in #243 (through 2d88f07 )

jtimon added a commit to jtimon/elements-explorer that referenced this pull request Sep 3, 2017
@jtimon
Daemon: Elements: Restore branch in ElementsProject/elements#185
81bb0de
@jtimon jtimon force-pushed the e14-rpc-plotter branch from 1761307 to 2d29548 Compare May 14, 2018 20:45
@jtimon
Copy link
Copy Markdown
Contributor Author

jtimon commented May 14, 2018

Re-backported

@jtimon jtimon force-pushed the e14-rpc-plotter branch 3 times, most recently from 65a50cf to 92dab1d Compare May 15, 2018 16:38
@jtimon jtimon changed the title NOMERGE: Rpc: Introduce call for per-block fee statistics Rpc: Introduce call for per-block fee statistics May 15, 2018
@jtimon jtimon force-pushed the e14-rpc-plotter branch from 92dab1d to 164e8fd Compare May 15, 2018 18:40
jtimon and others added 4 commits May 16, 2018 00:52
@jtimon
Refactor: RPC: Separate GetBlockChecked() from getblock()
938b509 
This does not change functionality
@jtimon
RPC: Introduce getblockstats
bcb509c
@jtimon
Tests: Test new getblockstats RPC
9dde7d7 
Includes commit from Anthony Towns @ajtowns:

Tests: Save and load block and corresponding expected statistics
@ajtowns @jtimon
Tests: Add data file
b142b2c
@jtimon jtimon force-pushed the e14-rpc-plotter branch from 164e8fd to b142b2c Compare May 15, 2018 22:53
@instagibbs
Copy link
Copy Markdown
Contributor

instagibbs commented May 16, 2018

rawtransactions.py failing

@instagibbs instagibbs merged commit b142b2c into ElementsProject:elements-0.14.1 May 16, 2018
instagibbs added a commit that referenced this pull request May 16, 2018
@instagibbs
Merge #185: Rpc: Introduce call for per-block fee statistics
c849ded 
b142b2c Tests: Add data file (Anthony Towns)
9dde7d7 Tests: Test new getblockstats RPC (Jorge Timón)
bcb509c RPC: Introduce getblockstats (Jorge Timón)
938b509 Refactor: RPC: Separate GetBlockChecked() from getblock() (Jorge Timón)
@instagibbs
Copy link
Copy Markdown
Contributor

instagibbs commented May 16, 2018

unrelated, merging since it looks near-final upstream, minus stupid unicorns

@jtimon jtimon deleted the e14-rpc-plotter branch May 16, 2018 16:56
This was referenced Dec 4, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0.14.1 enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtimon @instagibbs @ajtowns