Skip to content

[upstream #10627] fixed listunspent rpc convert parameter#184

Merged
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from
tnakagawa:fixd-listunspent
Jun 22, 2017
Merged

[upstream #10627] fixed listunspent rpc convert parameter#184
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from
tnakagawa:fixd-listunspent

Conversation

@tnakagawa
Copy link
Copy Markdown
Contributor

No description provided.

@instagibbs
Copy link
Copy Markdown
Contributor

This appears to be a bug upstream in Core. Mind opening another PR there too to make sure we don't need this next rebase?

@instagibbs instagibbs changed the title fixed listunspent rpc convert parameter [upstream #10627] fixed listunspent rpc convert parameter Jun 19, 2017
@jtimon jtimon added the 0.14.1 label Jun 20, 2017
@jtimon
Copy link
Copy Markdown
Contributor

jtimon commented Jun 21, 2017

Perhaps also add { "listunspent", 4, "asset" } (only here, not upstream the asset field to bitcoin core, obviously).
Apart from that, utACK

@jtimon jtimon added the bug label Jun 21, 2017
@tnakagawa
Copy link
Copy Markdown
Contributor Author

tnakagawa commented Jun 22, 2017

'VRPCConvertParams' only set 'not string' parameters.

@instagibbs
Copy link
Copy Markdown
Contributor

instagibbs commented Jun 22, 2017 via email

@jtimon
Copy link
Copy Markdown
Contributor

jtimon commented Jun 22, 2017

Oh, right, my bad. Should correct #185 ...
re-utACK

@instagibbs instagibbs merged commit 9647e5c into ElementsProject:elements-0.14.1 Jun 22, 2017
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 789cb19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants