[upstream #10627] fixed listunspent rpc convert parameter#184
Merged
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from Jun 22, 2017
tnakagawa:fixd-listunspent
Merged
[upstream #10627] fixed listunspent rpc convert parameter#184instagibbs merged 1 commit intoElementsProject:elements-0.14.1from tnakagawa:fixd-listunspent
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from
tnakagawa:fixd-listunspent
Conversation
Contributor
|
This appears to be a bug upstream in Core. Mind opening another PR there too to make sure we don't need this next rebase? |
Contributor
|
Perhaps also add { "listunspent", 4, "asset" } (only here, not upstream the asset field to bitcoin core, obviously). |
Contributor
Author
|
'VRPCConvertParams' only set 'not string' parameters. |
Contributor
|
Yes only for no strings.
…On Jun 21, 2017 8:24 PM, "nakagawa" ***@***.***> wrote:
'VRPCConvertParams' can only set parameters other than strings?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgC04PCXvDt9HoIV_23LYURgGzp3M-_ks5sGbRagaJpZM4N9r8W>
.
|
Contributor
|
Oh, right, my bad. Should correct #185 ... |
apoelstra
approved these changes
Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.